Add auto approval flow for servicenow plugin #33885
Conversation
EdwardDowling
changed the title
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
EdwardDowling
force-pushed
the
edwarddowling/auto-approval
branch
from
3da88da to
8c87ccd
Compare
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
3 similar comments
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
|
@hugoShaka Can you take another look at this when you get a chance? |
Co-authored-by: Marco André Dinis <[email protected]>
Co-authored-by: Hugo Shaka <[email protected]>
EdwardDowling
force-pushed
the
edwarddowling/auto-approval
branch
from
5575271 to
e91157e
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
@EdwardDowling See the table below for backport results.
|
* Add initial servicenow auto approval * Stop servicenow healthcheck exiting early * Update servicenow plugin tests to handle auto approval flow * Add comment clarifying choice of identifier for servicenow plugin * Fix healthcheck error handling in servicenow plugin * Fix formatting errors * Add more context to logs * Fix logging in servicenow plugin * Update integrations/access/servicenow/config.go Co-authored-by: Marco André Dinis <[email protected]> * Remove supurfluous reqId in log * Remove unused sentinal error * Fix imports * Remove unused field * Fix formating * Change servicenow plugin to always post review updates * Refactor servicenow plugin auto approval flow * Update integrations/access/servicenow/app.go Co-authored-by: Hugo Shaka <[email protected]> * Add mock for healthcheck endpoint * Add missing check to skip test in OSS version --------- Co-authored-by: Marco André Dinis <[email protected]> Co-authored-by: Hugo Shaka <[email protected]>
* Add initial servicenow auto approval * Stop servicenow healthcheck exiting early * Update servicenow plugin tests to handle auto approval flow * Add comment clarifying choice of identifier for servicenow plugin * Fix healthcheck error handling in servicenow plugin * Fix formatting errors * Add more context to logs * Fix logging in servicenow plugin * Update integrations/access/servicenow/config.go * Remove supurfluous reqId in log * Remove unused sentinal error * Fix imports * Remove unused field * Fix formating * Change servicenow plugin to always post review updates * Refactor servicenow plugin auto approval flow * Update integrations/access/servicenow/app.go * Add mock for healthcheck endpoint * Add missing check to skip test in OSS version --------- Co-authored-by: Marco André Dinis <[email protected]> Co-authored-by: Hugo Shaka <[email protected]>
Adds auto approval flow to servicenow so users with roles that have a 'schedule' annotation set will be checked to see if they are on-call in the specified rota.
PR adds the functionality to the servicenow plugin's implementation of 'app', the pr to actually use the use custom app is here
changelog: Add auto approval flow to servicenow plugin