Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 16.4.0 #46739

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Release 16.4.0 #46739

merged 1 commit into from
Sep 18, 2024

Conversation

r0mant
Copy link
Collaborator

@r0mant r0mant commented Sep 18, 2024

No description provided.

Copy link

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

CHANGELOG.md Outdated
@@ -1,5 +1,51 @@
# Changelog

## 16.4.0 (09/18/2024)

### Machine ID for Terraform Cloud
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timothyb89 should we say Terraform Enterprise instead?

Can we add the docs link here too?

Copy link
Contributor

@timothyb89 timothyb89 Sep 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, hmm. I think officially the name is HCP Terraform, and Terraform Enterprise is the separate self hosted version of that, which we also support. They renamed it from Terraform Cloud earlier this year. I think it's best if we say:

Machine ID for HCP Terraform and Terraform Enterprise

The v16 docs backport is in the merge queue. They're available at https://goteleport.com/docs/ver/17.x/admin-guides/infrastructure-as-code/terraform-provider/terraform-cloud/ for the moment.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we can have docs links in changelogs unfortunately because docs linter will fail saying we can't have absolute links. And having a relative link here will not play well with our Downloads page because it parses the changelog from here.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a really awkward limitation that we should fix. The changelog is one of the most important places to have docs links!

cc @xinding33 @ptgott can we make this a docs team goal for Q4?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, agreed.

CHANGELOG.md Outdated

Teleport now supports web application access where one application depends on
another. For example, you may have a web application that depends on a backend
API service, of which are separate apps protected by Teleport.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
API service, of which are separate apps protected by Teleport.
API service, both of which are separate apps protected by Teleport.

Copy link

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

Copy link

🤖 Vercel preview here: https://docs-3hv1urknn-goteleport.vercel.app/docs/ver/preview

@r0mant r0mant added this pull request to the merge queue Sep 18, 2024
Merged via the queue into branch/v16 with commit e08d4e0 Sep 18, 2024
41 of 42 checks passed
@r0mant r0mant deleted the release/16.4.0 branch September 18, 2024 23:33
@camscale camscale added the no-changelog Indicates that a PR does not require a changelog entry label Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport helm no-changelog Indicates that a PR does not require a changelog entry size/sm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants