Clarify the wording on the device trust authorization dialog #47166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Cancel" was a bad name for the secondary button, because most users expect cancel will close the modal and do nothing else. The actual behavior is that the web session is launched either way, and the user is only choosing whether or not to allow it to be authorized for device trust. Closes #45478
zmb3
added
no-changelog
avatus
approved these changes
Oct 3, 2024
gzdunek
approved these changes
Oct 4, 2024
public-teleport-github-review-bot
bot
removed the request for review
from ravicious
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Cancel" was a bad name for the secondary button, because most users expect cancel will close the modal and do nothing else. The actual behavior is that the web session is launched either way, and the user is only choosing whether or not to allow it to be authorized for device trust.
Closes #45478