[v16] Expose client tools auto update for find endpoint #47213
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Expose client tools auto update for find endpoint * Group auto update settings in find response Log error instead returning error Add tests auto update settings in find endpoint Add check for not implemented error * Add more test cases
vapopov
added
backport
no-changelog
|
@sclevine are there going to be any changes required/desired to this endpoint/message to accommodate any of the new upgrades design that we should do prior to merging backports? |
* Update client autoupdate proto structure * Replace with reserved * Fix unit tests * Add more info in proto * Rename proto to be aligned RFD namings * Replace enum type for ToolsMode to string
|
@rosstimothy I've cherry picked recent changes in proto structure here as well |
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
sclevine
reviewed
Nov 8, 2024
| // ToolsVersion defines the version of {tsh, tctl} for client auto update. | ||
| ToolsVersion string `json:"tools_version"` | ||
| // ToolsMode defines mode client auto update feature `enabled|disabled`. | ||
| ToolsMode string `json:"tools_mode"` |
There was a problem hiding this comment.
@vapopov I think this should be tools_auto_update?
https://github.com/gravitational/teleport/blob/master/api/client/webclient/webclient.go#L363
|
Should this PR be closed in favor of #48645? |
|
closing in favor #48645 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #46785 and #47532 to branch/v16