-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix RDS Aurora enrollment security group tips #47930
fix RDS Aurora enrollment security group tips #47930
Conversation
This pull request is automatically being deployed by Amplify Hosting (learn more). |
This pull request is automatically being deployed by Amplify Hosting (learn more). |
web/packages/teleport/src/Discover/Database/DeployService/AutoDeploy/SelectSecurityGroups.tsx
Outdated
Show resolved
Hide resolved
de4f3ac
to
0b87111
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i dont think we need to be checking if !securityGroups
at all, is there a reason why? 🤔
this component SelectSecurityGroups.tsx
does the fetching of security groups on intial render.
if the fetchign failed for some reason, then we should not be rendering things that require the security groups to be processed (thats a bug)
general ui pattern looks like this with api fetching:
if attempt.status === processing
-> render loader
if attempt.status === failed
-> render error banner
if attempt.status === success
-> then render the stuff that uses the data we were expecting, since we expect data to be defined here, we dont need to check for optional?
web/packages/teleport/src/Discover/Database/DeployService/AutoDeploy/SelectSecurityGroups.tsx
Outdated
Show resolved
Hide resolved
web/packages/teleport/src/Discover/Database/DeployService/AutoDeploy/SelectSecurityGroups.tsx
Outdated
Show resolved
Hide resolved
web/packages/teleport/src/Discover/Database/DeployService/AutoDeploy/SelectSecurityGroups.tsx
Show resolved
Hide resolved
web/packages/teleport/src/Discover/Database/DeployService/AutoDeploy/SelectSecurityGroups.tsx
Outdated
Show resolved
Hide resolved
web/packages/teleport/src/Discover/Database/DeployService/AutoDeploy/SelectSecurityGroups.tsx
Outdated
Show resolved
Hide resolved
web/packages/teleport/src/Discover/Database/DeployService/AutoDeploy/SelectSecurityGroups.tsx
Outdated
Show resolved
Hide resolved
web/packages/teleport/src/Discover/Database/DeployService/AutoDeploy/SelectSecurityGroups.tsx
Outdated
Show resolved
Hide resolved
703dad4
to
3fa70d8
Compare
web/packages/teleport/src/Discover/Database/DeployService/AutoDeploy/SelectSecurityGroups.tsx
Outdated
Show resolved
Hide resolved
web/packages/teleport/src/Discover/Database/DeployService/AutoDeploy/SelectSecurityGroups.tsx
Outdated
Show resolved
Hide resolved
3fa70d8
to
ab2d69f
Compare
@GavinFrazar See the table below for backport results.
|
Changelog: Fixed a bug that prevented selecting security groups during the Aurora database enrollment wizard in the web UI.
Fixes security group tips for RDS aurora mysql/postgres. We weren't populating the security groups for aurora cluster before, so it would throw an error when fetching the security groups to select from.