Teleport Connect allow SSO hostname #48035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joerger
changed the title
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
This was referenced Oct 28, 2024
Closed
ravicious
reviewed
Oct 29, 2024
lib/web/apiserver.go
Outdated
There was a problem hiding this comment.
What's the backward compatibility story going to look like here wrt SSO MFA? Do we run into a risk of Connect v17 wanting to use SSO MFA but not being able to because the proxy is on an older version which does not send SSOHostname?
There was a problem hiding this comment.
SSO MFA is being released in v17 so if we can get this in for v17.0.0 we won't have any issues.
gzdunek
reviewed
Oct 29, 2024
web/packages/teleterm/src/mainProcess/rootClusterProxyHostAllowList.ts
Outdated
Show resolved
Hide resolved
ravicious
reviewed
Oct 30, 2024
Joerger
added
the
no-changelog
gzdunek
approved these changes
Oct 31, 2024
ravicious
reviewed
Nov 4, 2024
web/packages/teleterm/src/mainProcess/rootClusterProxyHostAllowList.ts
Outdated
Show resolved
Hide resolved
ravicious
approved these changes
Nov 5, 2024
web/packages/teleterm/src/mainProcess/rootClusterProxyHostAllowList.ts
Outdated
Show resolved
Hide resolved
web/packages/teleterm/src/mainProcess/rootClusterProxyHostAllowList.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Teleport Connect's proxy host allow list to allow opening an SSO provider's hostname.
When pinging the Teleport proxy for a specific connector, include the SSO hostname so it can be included in client-side logic determining whether a URL hostname should be trusted or not. This allow list logic only currently presides in Connect, but we may want to consider adding it to
tshandtctlas well.Note: This change is necessary for SSO MFA to work in Connect, as Connect opens the URL within the context of the proxy host allow list.