Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend email plugin settings api #48048

Merged
merged 11 commits into from
Oct 30, 2024
Merged

Extend email plugin settings api #48048

merged 11 commits into from
Oct 30, 2024

Conversation

bernardjkim
Copy link
Contributor

This PR extends the plugin spec API to support Email Plugin settings.
This changes is required to support hosted Email plugins.

@bernardjkim bernardjkim added access-requests no-changelog Indicates that a PR does not require a changelog entry labels Oct 28, 2024
@github-actions github-actions bot added size/md tctl tctl - Teleport admin tool ui labels Oct 28, 2024
@aws-amplify-us-west-2 AWS Amplify (us-west-2)
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-48048.d3pp5qlev8mo18.amplifyapp.com

hugoShaka
hugoShaka approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@hugoShaka hugoShaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, do we need to block the SMTP mode of the plugin in cloud to avoid being used to probe SMTP servers or send spam? (here is not the right PR for this, if we block SMTP on cloud this should happen in the next teleport.e PR)

api/proto/teleport/legacy/types/types.proto Outdated Show resolved Hide resolved
@bernardjkim
Copy link
Contributor Author

do we need to block the SMTP mode of the plugin in cloud to avoid being used to probe SMTP servers or send spam?

That's a valid concern. I'll omit the SMTP option in the WebUI.

@github-actions GitHub Actions
Copy link

🤖 Vercel preview here: https://docs-882ntap9u-goteleport.vercel.app/docs/ver/preview

@github-actions GitHub Actions
Copy link

🤖 Vercel preview here: https://docs-ql7amppcj-goteleport.vercel.app/docs/ver/preview

@hugoShaka
Copy link
Contributor

That's a valid concern. I'll omit the SMTP option in the WebUI.

Even if it's not in the web UI, you can create the plugin manually in the CLI, the backend service will need to reject those if modules.IsCloud()

@bernardjkim
Address feedback
b4f5ab5 
- Set enum 0 as UNSPECIFIED
- Update enum names
@github-actions GitHub Actions
Copy link

🤖 Vercel preview here: https://docs-eigat949v-goteleport.vercel.app/docs/ver/preview

@github-actions GitHub Actions
Copy link

🤖 Vercel preview here: https://docs-bkelgebts-goteleport.vercel.app/docs/ver/preview

@bernardjkim bernardjkim enabled auto-merge October 30, 2024 03:29
@github-actions GitHub Actions
Copy link

🤖 Vercel preview here: https://docs-8ym6gm98k-goteleport.vercel.app/docs/ver/preview

@github-actions GitHub Actions
Copy link

🤖 Vercel preview here: https://docs-m1kd6xoig-goteleport.vercel.app/docs/ver/preview

@bernardjkim bernardjkim added this pull request to the merge queue Oct 30, 2024
Merged via the queue into master with commit 3922335 Oct 30, 2024
46 checks passed
@bernardjkim bernardjkim deleted the bernard/email-plugin-api branch October 30, 2024 17:08
@public-teleport-github-review-bot
Copy link

@bernardjkim See the table below for backport results.

Branch Result
branch/v15 Failed
branch/v16 Failed
branch/v17 Create PR

bernardjkim added a commit that referenced this pull request Nov 7, 2024
@bernardjkim
Extend email plugin settings api (#48048)
fd9ce34
@bernardjkim bernardjkim mentioned this pull request Nov 7, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Nov 7, 2024
@bernardjkim
Extend email plugin settings api (#48048) (#48606)
2eaafdc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugoShaka hugoShaka hugoShaka approved these changes

@tigrato tigrato tigrato approved these changes

@marcoandredinis marcoandredinis marcoandredinis approved these changes

Assignees
No one assigned
Labels
access-requests backport/branch/v15 backport/branch/v16 backport/branch/v17 no-changelog Indicates that a PR does not require a changelog entry size/md tctl tctl - Teleport admin tool ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bernardjkim @hugoShaka @marcoandredinis @tigrato