Prevent expanding/collapsing a notification when clicking the action button #48074
Conversation
gzdunek
added
no-changelog
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
| content: action.content, | ||
| onClick: event => { | ||
| // Prevents toggling the isExpanded flag. | ||
| event.stopPropagation(); |
There was a problem hiding this comment.
Is there any way we can add a test for this? It's a rather niche interaction that can easily regress in the future. OTOH, as isExpanded merely controls the styles, I don't think the JSDOM-based tests are going to be able to detect the difference.
There was a problem hiding this comment.
Yeah, we can't detect the text overflow. Instead, I added a test that checks if the style wasn't modified by the click. What do you think?
There was a problem hiding this comment.
That should be good enough for now! I didn't realize that toHaveStyleRule works with CSS in general, I've always assumed it only works when the style is set directly on a node.
public-teleport-github-review-bot
bot
removed request for
ryanclark,
bl-nero and
rudream
Clicking on the action button should not expand/collapse notifications:
notification.mov