Align label sorting in Connect with what Web UI does #48086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ravicious
added
no-changelog
zmb3
approved these changes
Oct 29, 2024
kimlisa
approved these changes
Oct 29, 2024
public-teleport-github-review-bot
bot
removed the request for review
from gzdunek
gzdunek
approved these changes
Oct 30, 2024
|
@ravicious See the table below for backport results.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #34332.
When going through the test plan, I've noticed that Connect sorts resource labels differently than the Web UI. This was historically kind of a PITA to take care of. But thanks to the refactor with
lib/uithat @kimlisa recently did, it's now super straightforward.I've mostly copied what is done in
lib/web/ui/server.go.Web UI reference: