Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated grpc-js start() method calls #48114

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Remove deprecated grpc-js start() method calls #48114

merged 1 commit into from
Oct 30, 2024

Conversation

gzdunek
Copy link
Contributor

@gzdunek gzdunek commented Oct 30, 2024

This gets rid of the following warnings:

(node:35715) DeprecationWarning: Calling start() is no longer necessary. It can be safely omitted.
(Use Electron Helper (Renderer) --trace-deprecation ... to show where the warning was created)

@gzdunek gzdunek added no-changelog Indicates that a PR does not require a changelog entry backport/branch/v17 labels Oct 30, 2024
@gzdunek gzdunek requested a review from ravicious October 30, 2024 08:07
@github-actions github-actions bot requested a review from kiosion October 30, 2024 08:08
@gzdunek gzdunek requested a review from bl-nero October 30, 2024 08:08
@aws-amplify-us-west-2 AWS Amplify (us-west-2)
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-48114.d3pp5qlev8mo18.amplifyapp.com

ravicious
ravicious approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@ravicious ravicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. I didn't pay that much attention to this warning so I've always assumed it's something that Electron does somewhere.

@gzdunek gzdunek added this pull request to the merge queue Oct 30, 2024
Merged via the queue into master with commit e3e6211 Oct 30, 2024
42 of 43 checks passed
@gzdunek gzdunek deleted the gzdunek/remove-grpc-js-deprecations branch October 30, 2024 15:32
@public-teleport-github-review-bot
Copy link

@gzdunek See the table below for backport results.

Branch Result
branch/v17 Create PR

@gzdunek gzdunek mentioned this pull request Oct 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmb3 zmb3 zmb3 approved these changes

@ravicious ravicious ravicious approved these changes

Assignees
No one assigned
Labels
backport/branch/v17 no-changelog Indicates that a PR does not require a changelog entry size/sm ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gzdunek @ravicious @zmb3