Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Provisioning States via Cache interface #48115

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

tcsc
Copy link
Contributor

@tcsc tcsc commented Oct 30, 2024

No description provided.

@tcsc tcsc added the no-changelog Indicates that a PR does not require a changelog entry label Oct 30, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-48115.d3pp5qlev8mo18.amplifyapp.com

// DownstreamProvisioningStates defines an interface for managing principal
// provisioning state records scoped by a target downstream receiver.
type DownstreamProvisioningStates interface {
type DownstreamProvisioningStateGetter interface {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this going to be used later?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, This interface will be use in e https://github.com/gravitational/teleport.e/pull/5191

}
defer rg.Release()

return rg.reader.GetProvisioningState(ctx, downstream, id)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this going to benefit from having a read through on NotFound? We have that for some point get operations.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be added later. Currently, there doesn’t seem to be a case where GetProvisioningState needs to reach the backend when NotFound. The AWS IC provisioning logic is self-healing, so if the provisioning state hasn’t yet successfully propagated to the cache, the provisioning operation will be retried.

@public-teleport-github-review-bot public-teleport-github-review-bot bot removed the request for review from bernardjkim October 30, 2024 09:31
@smallinsky smallinsky enabled auto-merge October 30, 2024 09:41
@smallinsky smallinsky added this pull request to the merge queue Oct 30, 2024
Merged via the queue into master with commit 57daece Oct 30, 2024
43 checks passed
@smallinsky smallinsky deleted the tcsc/expose-provisioning-states branch October 30, 2024 10:00
@public-teleport-github-review-bot

@tcsc See the table below for backport results.

Branch Result
branch/v17 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/branch/v17 no-changelog Indicates that a PR does not require a changelog entry size/sm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants