-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose Provisioning States via Cache interface #48115
Conversation
This pull request is automatically being deployed by Amplify Hosting (learn more). |
// DownstreamProvisioningStates defines an interface for managing principal | ||
// provisioning state records scoped by a target downstream receiver. | ||
type DownstreamProvisioningStates interface { | ||
type DownstreamProvisioningStateGetter interface { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this going to be used later?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, This interface will be use in e https://github.com/gravitational/teleport.e/pull/5191
} | ||
defer rg.Release() | ||
|
||
return rg.reader.GetProvisioningState(ctx, downstream, id) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this going to benefit from having a read through on NotFound? We have that for some point get operations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be added later. Currently, there doesn’t seem to be a case where GetProvisioningState needs to reach the backend when NotFound. The AWS IC provisioning logic is self-healing, so if the provisioning state hasn’t yet successfully propagated to the cache, the provisioning operation will be retried.
No description provided.