Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v16] Extend resource access request validation checks #48137

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

zmb3
Copy link
Collaborator

@zmb3 zmb3 commented Oct 30, 2024

Backport #48079 to branch/v16

In #46780 we put a cap on the total number of resources that can
be requested in a single request, which helps avoid situations
where a large access request can exceed resource size limits and
break request listing.

This change expands on the validations by also checking that the sum
of the lengths of all of the requested IDs stays below a reasonable
limit.
@zmb3 zmb3 added the no-changelog Indicates that a PR does not require a changelog entry label Oct 30, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-48137.d212ksyjt6y4yg.amplifyapp.com

@zmb3 zmb3 enabled auto-merge October 30, 2024 21:52
@zmb3 zmb3 added this pull request to the merge queue Nov 1, 2024
@public-teleport-github-review-bot public-teleport-github-review-bot bot removed the request for review from nklaassen November 1, 2024 09:38
Merged via the queue into branch/v16 with commit 063d3ae Nov 1, 2024
42 of 43 checks passed
@zmb3 zmb3 deleted the bot/backport-48079-branch/v16 branch November 1, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport no-changelog Indicates that a PR does not require a changelog entry size/sm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants