[v17] Extend resource access request validation checks #48138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #46780 we put a cap on the total number of resources that can be requested in a single request, which helps avoid situations where a large access request can exceed resource size limits and break request listing. This change expands on the validations by also checking that the sum of the lengths of all of the requested IDs stays below a reasonable limit.
zmb3
added
the
no-changelog
rosstimothy
approved these changes
Oct 30, 2024
marcoandredinis
approved these changes
Nov 1, 2024
public-teleport-github-review-bot
bot
removed the request for review
from nklaassen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #48079 to branch/v17