Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v17] Remove nested tabs from docs pages #48140

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

ptgott
Copy link
Contributor

@ptgott ptgott commented Oct 30, 2024

Backport #47862 to branch/v17

@ptgott ptgott added the no-changelog Indicates that a PR does not require a changelog entry label Oct 30, 2024
Copy link

🤖 Vercel preview here: https://docs-8bf5edoi4-goteleport.vercel.app/docs/ver/preview

@public-teleport-github-review-bot public-teleport-github-review-bot bot removed the request for review from stevenGravy October 30, 2024 17:38
@ptgott ptgott enabled auto-merge October 30, 2024 18:25
ptgott and others added 2 commits October 30, 2024 14:25
Closes #35870

Used the following command to find nested tabs:

```
$ find docs/pages -name "*.mdx" -exec awk '
/<TabItem/{ti=1}
ti==1 && /<\/TabItem/{ti=0}
ti==1 && /<Tabs/{n=1;if(lines=="") lines=FNR; else lines=(lines "," FNR)}
END{if(n>0) print FILENAME ":" lines}' {} \;
```

Edit the following guides:

- **Connect your Client intro:** Remove branching between Community
  Edition and Teleport Enterprise. The only difference was the
  assumption that Community Edition users would only have a GitHub
  connector available. But if users must ask their administrator for an
  SSO connector name anyway, we don't need to specify the connector name
  here.
- **GUI clients:** Use separate H4s to describe using a local proxy
  server and getting remote host information.
- **Self-Signed Certs:** Don't use tabs to explain the difference in
  syntax between using `--set` and a values file in Helm. Instead, use
  inline prose.
- **Locking:** Explain both the CAP and static config file in the
  "Self-Hosted" tab.
- **AWS Helm deployment:** Remove the Community Edition tab in Step 5
  and explain how to disable the `enterprise` field using a YAML comment
- **Kubernetes AWS auto-discovery:** Collapse `aws-auth` and `eks
  create-access-entry` instructions into a single passage of text.
@ptgott ptgott force-pushed the bot/backport-47862-branch/v17 branch from 73546d2 to ffdb82c Compare October 30, 2024 18:25
Copy link

🤖 Vercel preview here: https://docs-8qrz1rhuv-goteleport.vercel.app/docs/ver/preview

@ptgott ptgott added this pull request to the merge queue Oct 30, 2024
Merged via the queue into branch/v17 with commit 6a998dd Oct 30, 2024
40 checks passed
@ptgott ptgott deleted the bot/backport-47862-branch/v17 branch October 30, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport documentation no-changelog Indicates that a PR does not require a changelog entry size/sm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants