Fix upgrade window periodics #48211
Merged
Fix upgrade window periodics #48211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#47731 consolidated the auth periodics to use a multi.Interval, however the upgrade window check called from the periodic launched it's own periodic, leading to a runaway number of upgrade window checks. This removes the extra periodic to reduce load upstream.
rosstimothy
added
backport/branch/v14
no-changelog
espadolini
approved these changes
Oct 31, 2024
jimbishopp
approved these changes
Oct 31, 2024
public-teleport-github-review-bot
bot
removed request for
avatus and
greedy52
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
|
@rosstimothy See the table below for backport results.
|
This was referenced Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#47731 consolidated the auth periodics to use a multi.Interval, however the upgrade window check called from the periodic launched it's own periodic, leading to a runaway number of upgrade window checks. This removes the extra periodic to reduce load upstream. The problem only affects the Teleport Cloud control plane.