[Web] Fix availability filter on unified resources not updating results immediately #48806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rudream
added
no-changelog
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
gzdunek
reviewed
Nov 12, 2024
web/packages/teleport/src/components/hooks/useUrlFiltering/useUrlFiltering.ts
Outdated
Show resolved
Hide resolved
ravicious
reviewed
Nov 13, 2024
web/packages/teleport/src/components/hooks/useUrlFiltering/useUrlFiltering.ts
Show resolved
Hide resolved
ravicious
approved these changes
Nov 14, 2024
web/packages/teleport/src/components/hooks/useUrlFiltering/useUrlFiltering.ts
Outdated
Show resolved
Hide resolved
web/packages/teleport/src/components/hooks/useUrlFiltering/useUrlFiltering.ts
Outdated
Show resolved
Hide resolved
rudream
force-pushed
the
yassine/fix-availability-filter
branch
from
d992678 to
d7f1c35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR resolves #48469
Fixes a bug where changing the "Show requestable resources" filter on the unified resources page would not update results immediately. This was because recent changes to the
useUrlFilteringlogic relied entirely on the URL as the source of truth, but this particular filter is not stored in the URL query params.