Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix K8s Port Forward audit log event #49109

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Fix K8s Port Forward audit log event #49109

merged 1 commit into from
Dec 6, 2024

Conversation

creack
Copy link
Member

@creack creack commented Nov 16, 2024

  • Emit port forward event only once at setup instead than upon each connection
  • Include k8s cluster info in event

Fixes #48452

@creack creack self-assigned this Nov 16, 2024
@creack creack added the no-changelog Indicates that a PR does not require a changelog entry label Nov 17, 2024
rosstimothy
rosstimothy approved these changes Nov 18, 2024
View reviewed changes
lib/kube/proxy/forwarder.go Outdated Show resolved Hide resolved
lib/kube/proxy/forwarder.go Outdated Show resolved Hide resolved
tigrato
tigrato reviewed Nov 18, 2024
View reviewed changes
lib/kube/proxy/forwarder.go Outdated Show resolved Hide resolved
lib/kube/proxy/forwarder.go Show resolved Hide resolved
@creack creack force-pushed the creack/fix-k8s-port-fw-audit-events branch 2 times, most recently from 491d4c3 to ef41c2e Compare December 6, 2024 16:46
@creack
Emit port-forward event only the first time, add port-forward-end eve…
2fe5375 
…nt. Include cluster and pod metadta in event.
@creack creack force-pushed the creack/fix-k8s-port-fw-audit-events branch from ef41c2e to 2fe5375 Compare December 6, 2024 16:54
@creack creack enabled auto-merge December 6, 2024 17:14
@creack creack added this pull request to the merge queue Dec 6, 2024
Merged via the queue into master with commit 58a6fe7 Dec 6, 2024
45 checks passed
@creack creack deleted the creack/fix-k8s-port-fw-audit-events branch December 6, 2024 17:51
@public-teleport-github-review-bot
Copy link

@creack See the table below for backport results.

Branch Result
branch/v15 Failed
branch/v16 Failed
branch/v17 Failed

This was referenced Dec 6, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rosstimothy rosstimothy rosstimothy approved these changes

@tigrato tigrato tigrato approved these changes

Assignees

@creack creack

Labels
backport/branch/v15 backport/branch/v16 backport/branch/v17 kubernetes-access no-changelog Indicates that a PR does not require a changelog entry size/sm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Kubernetes Cluster and Resource Metadata to PortForward Event
3 participants
@creack @tigrato @rosstimothy