Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crdgen: Update testdata #49375

Merged
merged 3 commits into from
Dec 2, 2024
Merged

crdgen: Update testdata #49375

merged 3 commits into from
Dec 2, 2024

Conversation

bernardjkim
Copy link
Contributor

This PR updates the crdgen testdata following the CONTRIBUTING.md guideline.

In a clean repo before making any changes:

1. Run `make manifests`.
2. Run `make -C crdgen update-protos`.
3. Run `make -C crdgen update-snapshot`.

@bernardjkim bernardjkim added the no-changelog Indicates that a PR does not require a changelog entry label Nov 22, 2024
@public-teleport-github-review-bot public-teleport-github-review-bot bot removed the request for review from tigrato November 25, 2024 09:23
@bernardjkim bernardjkim added this pull request to the merge queue Dec 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 2, 2024
@bernardjkim bernardjkim added this pull request to the merge queue Dec 2, 2024
Merged via the queue into master with commit 6995108 Dec 2, 2024
40 checks passed
@bernardjkim bernardjkim deleted the bernard/update-crdgen-testdata branch December 2, 2024 20:10
bernardjkim added a commit that referenced this pull request Dec 2, 2024
@bernardjkim
crdgen: Update testdata (#49375)
b04aa9a 
* Update crdgen testdata

* Update CONTRIBUTING.md
@bernardjkim bernardjkim mentioned this pull request Dec 2, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Dec 3, 2024
@bernardjkim
crdgen: Update testdata (#49375) (#49670)
d20c267 
* Update crdgen testdata

* Update CONTRIBUTING.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugoShaka hugoShaka hugoShaka approved these changes

@tigrato tigrato tigrato approved these changes

@marcoandredinis marcoandredinis marcoandredinis approved these changes

Assignees
No one assigned
Labels
no-changelog Indicates that a PR does not require a changelog entry size/lg
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bernardjkim @marcoandredinis @tigrato @hugoShaka