Remove "namespace" parameters from various helpers #49515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codingllama
added
the
no-changelog
|
I suggest reviewing commit-by-commit, as it should make the changes more obvious. |
codingllama
force-pushed
the
codingllama/namespace-cleanup
branch
from
86943f6 to
66f89cb
Compare
|
Rebased onto fresh master to fix a few newly-added tests. |
|
Friendly ping @Joerger @rosstimothy @fspmarshall ? |
fspmarshall
approved these changes
Dec 2, 2024
Joerger
approved these changes
Dec 2, 2024
public-teleport-github-review-bot
bot
removed the request for review
from rosstimothy
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the namespace parameters from various helpers that flow into authz checks.
This serves a dual purpose:
I've painstakingly followed the changed calls to make sure they always passed apidefaults.Namespace as the parameter, so assuming I didn't miss anything this PR is largely a noop.
Exceptions to the above are on commit 86943f6 - Nodes/Servers already don't accept non-"default" namespaces (see ae99259) and "saml_idp_service_provider" seems to be only following the surrounding code (as in it doesn't really work for non-default namespaces).
After the changes it's clear that only 14-ish calls to ServerWithRoles.actionNamespace remain. These are largely contained to Nodes/Servers, Apps and Databases, the older Teleport resources that use namespaced storage keys.
#49509