Role editor: hierarchical validation and tabs #49546
Conversation
Adds a model-level validation capability to our validation library.
They will be later required in the SlideTabs component
Add support for tooltips and status icons
bl-nero
added
the
no-changelog
| }; | ||
|
|
||
| export type KubernetesResourceKind = |
There was a problem hiding this comment.
is there some backend equivalent that we are keeping this in line with? Could we maybe add a comment linking to it?
| <H2>{isCreating ? 'Create a New Role' : role?.metadata.name}</H2> | ||
| <Flex alignItems="center" mb={3} gap={2}> | ||
| <Box flex="1"> | ||
| <H2>{isCreating ? 'Create a New Role' : role?.metadata.name}</H2> |
There was a problem hiding this comment.
Mentioning "Edit Role" is not necessary for editing? Edit Role {role?.metadata.name}
There was a problem hiding this comment.
Right, this may be clearer.
| isProcessing={isProcessing} | ||
| onChange={setStandardModel} | ||
| /> | ||
| <div id={standardEditorId}> |
There was a problem hiding this comment.
why is <div id={standardEditorId} needed?
There was a problem hiding this comment.
These are used to associate the tab switcher tabs with the switched panels. I'm adding a comment.
| }; | ||
| export type WindowsDesktopSpecValidationResult = RuleSetValidationResult< | ||
| typeof windowsDesktopSpecValidationRules | ||
| >; |
There was a problem hiding this comment.
nit: all the rules functions in this file would have a better home in a separate rule.ts file
There was a problem hiding this comment.
Yes, I agree. The only reason I didn't make it is that I'm constantly in progress with more PRs, so after the version cut, I'm planning to split both the StandardEditor file, as well as this one.
There was a problem hiding this comment.
(Oh, wait. This is actually new code. It can be easily extracted.)
* Validation Adds a model-level validation capability to our validation library. * Move tooltips to the design package They will be later required in the SlideTabs component * SlideTabs improvements Add support for tooltips and status icons * Role editor: hierarchical validation and tabs * Review * Also, rename the tooltip directory * Fix an import * Review: status-related props, extract StatusIcon * Update after changing the SlideTabs interface * Also, rename the tooltip component * review * review * REview * Never return undefined from useValidation()
* Validation Adds a model-level validation capability to our validation library. * Move tooltips to the design package They will be later required in the SlideTabs component * SlideTabs improvements Add support for tooltips and status icons * Role editor: hierarchical validation and tabs * Review * Also, rename the tooltip directory * Fix an import * Review: status-related props, extract StatusIcon * Update after changing the SlideTabs interface * Also, rename the tooltip component * review * review * REview * Never return undefined from useValidation()
This PR moves the role editor UI to a two-level tab hierarchy. It also uses a new approach to validation, which is necessary, because the design requires errors to be visible on multiple levels of the hierarchy. New validation rules are also added to bring the UI up to reasonable parity with the backend requirements.
To turn on the new UI, go to developer tools -> Application -> Local storage and add a
grv_teleport_use_new_role_editorkey set totrue. This will be lifted once UI is good to be released.Demo
Requires #49545
Contributes to #46612