Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub proxy part 2.5: git_server cache #49564

Merged
merged 5 commits into from
Dec 5, 2024
Merged

GitHub proxy part 2.5: git_server cache #49564

merged 5 commits into from
Dec 5, 2024

Conversation

greedy52
Copy link
Contributor

@greedy52 greedy52 self-assigned this Nov 28, 2024
@greedy52 greedy52 added the no-changelog Indicates that a PR does not require a changelog entry label Nov 28, 2024
@greedy52 greedy52 changed the title GitHub proxy part 4: git_server cache GitHub proxy part 2.5: git_server cache Nov 28, 2024
@greedy52 greedy52 mentioned this pull request Nov 28, 2024
Open
15 tasks
@greedy52 greedy52 force-pushed the STeve/48762_git_server_cache branch from 868edd9 to 7cb9ae7 Compare November 28, 2024 22:34
greedy52
greedy52 commented Nov 28, 2024
View reviewed changes
api/client/client.go
Comment on lines +4880 to +4881
func (c *Client) GitServerClient() *gitserverclient.Client {
return gitserverclient.NewClient(gitserverpb.NewGitServerServiceClient(c.conn))
Copy link
Contributor Author

@greedy52 greedy52 Nov 28, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unfortunately, i realize i need a wrapper so it uses the same interface as the cache.

rest of the code just standard caching

@greedy52 greedy52 force-pushed the STeve/48762_git_server_cache branch from 7cb9ae7 to 4f654a0 Compare November 29, 2024 01:07
@greedy52 greedy52 marked this pull request as ready for review November 29, 2024 01:08
@github-actions github-actions bot added size/md tctl tctl - Teleport admin tool labels Nov 29, 2024
@greedy52 greedy52 requested a review from espadolini December 2, 2024 18:49
@greedy52
Copy link
Contributor Author

greedy52 commented Dec 4, 2024

friendly ping @espadolini @smallinsky @GavinFrazar

GavinFrazar
GavinFrazar approved these changes Dec 5, 2024
View reviewed changes
lib/cache/cache.go Outdated Show resolved Hide resolved
lib/cache/git_server.go Outdated Show resolved Hide resolved
api/client/gitserver/gitserver.go Outdated Show resolved Hide resolved
lib/services/local/git_server.go Outdated Show resolved Hide resolved
@greedy52 greedy52 added this pull request to the merge queue Dec 5, 2024
Merged via the queue into master with commit c4d0dc4 Dec 5, 2024
41 checks passed
@greedy52 greedy52 deleted the STeve/48762_git_server_cache branch December 5, 2024 03:38
@public-teleport-github-review-bot
Copy link

@greedy52 See the table below for backport results.

Branch Result
branch/v17 Failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GavinFrazar GavinFrazar GavinFrazar approved these changes

@r0mant r0mant r0mant approved these changes

@espadolini espadolini Awaiting requested review from espadolini

Assignees

@greedy52 greedy52

Labels
backport/branch/v17 no-changelog Indicates that a PR does not require a changelog entry size/md tctl tctl - Teleport admin tool
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@greedy52 @r0mant @espadolini @GavinFrazar