Workload ID: Add WorkloadIdentity CRUD gRPC Service #49639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strideynet
force-pushed
the
strideynet/workload-identity-crud
branch
from
688632f to
2dfbfcd
Compare
strideynet
changed the base branch from
master
to
strideynet/workload-identity-pbuf-and-events
strideynet
force-pushed
the
strideynet/workload-identity-crud
branch
from
2dfbfcd to
de0b12d
Compare
strideynet
added
backport/branch/v16
backport/branch/v17
no-changelog
strideynet
changed the title
|
@strideynet - this PR will require admin approval to merge due to its size. Consider breaking it up into a series smaller changes. |
strideynet
force-pushed
the
strideynet/workload-identity-crud
branch
from
07c4513 to
0233d81
Compare
strideynet
requested review from
klizhentas,
russjones,
r0mant,
zmb3,
fheinecke,
camscale,
tcsc,
rosstimothy and
codingllama
as code owners
strideynet
force-pushed
the
strideynet/workload-identity-pbuf-and-events
branch
from
514381a to
1a4ee2f
Compare
strideynet
force-pushed
the
strideynet/workload-identity-crud
branch
from
0233d81 to
a676d7e
Compare
strideynet
force-pushed
the
strideynet/workload-identity-pbuf-and-events
branch
from
1a4ee2f to
f560fad
Compare
espadolini
approved these changes
Dec 5, 2024
lib/services/workload_identity.go
Outdated
Comment on lines
105
to
112
| // Ensure exactly one operator is set. | ||
| operatorsSet := 0 | ||
| if condition.Equals != "" { | ||
| operatorsSet++ | ||
| } | ||
| if operatorsSet == 0 || operatorsSet > 1 { |
There was a problem hiding this comment.
Is this just in preparation for more than Equals?
There was a problem hiding this comment.
Yeah - that's correct. Eventually there will be 4-5 different operators. I've just omitted them from this PR because I want to wait until the RFD is firmed up and I didn't want to balloon this PR any bigger than it already is.
Base automatically changed from
strideynet/workload-identity-pbuf-and-events
to
master
December 6, 2024 12:00
strideynet
force-pushed
the
strideynet/workload-identity-crud
branch
from
be8e8b9 to
472b918
Compare
|
Going to split this PR out into 2/3 PRs to get the line count below XL limit. |
strideynet
force-pushed
the
strideynet/workload-identity-crud
branch
from
9fb2f88 to
75e38b9
Compare
strideynet
changed the base branch from
master
to
strideynet/add-workload-identity-service-and-cache
public-teleport-github-review-bot
bot
removed the request for review
from timothyb89
strideynet
changed the title
|
Cache/Local Service changes have been rebased into a new PR: #49942 |
espadolini
approved these changes
Dec 9, 2024
Base automatically changed from
strideynet/add-workload-identity-service-and-cache
to
master
December 10, 2024 09:42
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
@strideynet See the table below for backport results.
|
strideynet
added a commit
that referenced
this pull request
Dec 10, 2024
* Add WorkloadIdentity store and cache * Add WorkloadIdentity CRUD service
strideynet
added a commit
that referenced
this pull request
Dec 10, 2024
* Add WorkloadIdentity store and cache * Add WorkloadIdentity CRUD service
This was referenced Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #49572
Depends on #49942