-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
autoupdate: implement halt-on-error strategy #49737
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugoShaka
force-pushed
the
hugo/rollout-haltonerror-strategy
branch
from
December 3, 2024 23:13
07a6de2
to
3542788
Compare
hugoShaka
force-pushed
the
hugo/rollout-progress-common
branch
from
December 6, 2024 00:05
8c41768
to
06d909d
Compare
hugoShaka
force-pushed
the
hugo/rollout-haltonerror-strategy
branch
from
December 6, 2024 00:06
3542788
to
963c6de
Compare
hugoShaka
force-pushed
the
hugo/rollout-progress-common
branch
from
December 6, 2024 21:29
06d909d
to
296b736
Compare
hugoShaka
force-pushed
the
hugo/rollout-haltonerror-strategy
branch
from
December 9, 2024 18:35
963c6de
to
27b30f4
Compare
hugoShaka
added
the
no-changelog
Indicates that a PR does not require a changelog entry
label
Dec 9, 2024
hugoShaka
force-pushed
the
hugo/rollout-haltonerror-strategy
branch
from
December 10, 2024 15:19
b34b475
to
d0dc5ee
Compare
sclevine
reviewed
Dec 11, 2024
hugoShaka
force-pushed
the
hugo/rollout-haltonerror-strategy
branch
from
December 17, 2024 18:40
d0dc5ee
to
0487d7d
Compare
sclevine
approved these changes
Dec 17, 2024
Co-authored-by: Stephen Levine <[email protected]>
vapopov
approved these changes
Dec 17, 2024
r0mant
approved these changes
Dec 17, 2024
public-teleport-github-review-bot
bot
removed request for
Joerger and
smallinsky
December 17, 2024 21:10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: RFD-184
Goal (internal): https://github.com/gravitational/cloud/issues/10289
Requires: #49735
This PR imeplements the halt-on-error rollout strategy.
Note
The RFD uses wait_days to control when updates happen, but after followup discussions we decided to rename the field to wait_hours as this resolves most ambiguities. See #49737 (comment) for more details.