Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autoupdate: implement halt-on-error strategy #49737

Merged
merged 3 commits into from
Dec 17, 2024

Conversation

hugoShaka
Copy link
Contributor

@hugoShaka hugoShaka commented Dec 3, 2024

Part of: RFD-184

Goal (internal): https://github.com/gravitational/cloud/issues/10289

Requires: #49735

This PR imeplements the halt-on-error rollout strategy.

Note

The RFD uses wait_days to control when updates happen, but after followup discussions we decided to rename the field to wait_hours as this resolves most ambiguities. See #49737 (comment) for more details.

@hugoShaka hugoShaka requested review from sclevine and vapopov December 3, 2024 23:04
@hugoShaka hugoShaka force-pushed the hugo/rollout-haltonerror-strategy branch from 07a6de2 to 3542788 Compare December 3, 2024 23:13
@hugoShaka hugoShaka force-pushed the hugo/rollout-progress-common branch from 8c41768 to 06d909d Compare December 6, 2024 00:05
@hugoShaka hugoShaka force-pushed the hugo/rollout-haltonerror-strategy branch from 3542788 to 963c6de Compare December 6, 2024 00:06
@hugoShaka hugoShaka force-pushed the hugo/rollout-progress-common branch from 06d909d to 296b736 Compare December 6, 2024 21:29
Base automatically changed from hugo/rollout-progress-common to master December 6, 2024 22:19
@hugoShaka hugoShaka force-pushed the hugo/rollout-haltonerror-strategy branch from 963c6de to 27b30f4 Compare December 9, 2024 18:35
@hugoShaka hugoShaka marked this pull request as ready for review December 9, 2024 18:35
@hugoShaka hugoShaka added the no-changelog Indicates that a PR does not require a changelog entry label Dec 9, 2024
@hugoShaka hugoShaka force-pushed the hugo/rollout-haltonerror-strategy branch from b34b475 to d0dc5ee Compare December 10, 2024 15:19
@hugoShaka hugoShaka force-pushed the hugo/rollout-haltonerror-strategy branch from d0dc5ee to 0487d7d Compare December 17, 2024 18:40
@hugoShaka hugoShaka requested a review from sclevine December 17, 2024 18:43
lib/autoupdate/rollout/strategy_haltonerror.go Outdated Show resolved Hide resolved
lib/autoupdate/rollout/strategy_haltonerror.go Outdated Show resolved Hide resolved
lib/autoupdate/rollout/strategy_haltonerror_test.go Outdated Show resolved Hide resolved
@hugoShaka hugoShaka added this pull request to the merge queue Dec 17, 2024
Merged via the queue into master with commit 7d71be5 Dec 17, 2024
41 checks passed
@hugoShaka hugoShaka deleted the hugo/rollout-haltonerror-strategy branch December 17, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Indicates that a PR does not require a changelog entry size/lg
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants