Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: expandable content - customer feedback #49782

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

docs: expandable content - customer feedback #49782

wants to merge 7 commits into from
+3 −6

Conversation

mmcallister
Copy link
Contributor

@mmcallister mmcallister commented Dec 4, 2024 •
edited by zmb3
Loading

Closes #48644

@mmcallister mmcallister added no-changelog Indicates that a PR does not require a changelog entry backport/branch/v15 backport/branch/v16 labels Dec 4, 2024
@mmcallister mmcallister self-assigned this Dec 4, 2024
@mmcallister mmcallister linked an issue Dec 4, 2024 that may be closed by this pull request
docs: expandable content feedback from users #48644
Open
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024

🤖 Vercel preview here: https://docs-by36bx5ar-goteleport.vercel.app/docs

@mmcallister
Copy link
Contributor Author

mmcallister commented Dec 5, 2024 •
edited
Loading

The content still shows as closed by default. Editing the permission-warning reference to use an Admonition 'important' tag, and the networking page section to use an H3 instead of Details.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2024

🤖 Vercel preview here: https://docs-7jarl72nu-goteleport.vercel.app/docs

@mmcallister mmcallister marked this pull request as ready for review December 5, 2024 01:52
@github-actions github-actions bot requested review from r0mant, xinding33 and zmb3 December 5, 2024 01:52
@mmcallister mmcallister enabled auto-merge December 5, 2024 18:06
@mmcallister
Copy link
Contributor Author

@ptgott could you have a look at this one when you have a moment? ty!

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2024

🤖 Vercel preview here: https://docs-fmkknb7xy-goteleport.vercel.app/docs

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2024

🤖 Vercel preview here: https://docs-b0zbe7blx-goteleport.vercel.app/docs

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2024

🤖 Vercel preview here: https://docs-arahiy3cq-goteleport.vercel.app/docs

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024

🤖 Vercel preview here: https://docs-468ob7ibr-goteleport.vercel.app/docs

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024

🤖 Vercel preview here: https://docs-5mgn1jl0b-goteleport.vercel.app/docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptgott ptgott ptgott approved these changes

@stevenGravy stevenGravy Awaiting requested review from stevenGravy

@programmerq programmerq Awaiting requested review from programmerq

@r0mant r0mant Awaiting requested review from r0mant

@xinding33 xinding33 Awaiting requested review from xinding33

@zmb3 zmb3 Awaiting requested review from zmb3

At least 2 approving reviews are required to merge this pull request.

Assignees

@mmcallister mmcallister

Labels
backport/branch/v15 backport/branch/v16 backport/branch/v17 documentation no-changelog Indicates that a PR does not require a changelog entry size/sm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs: expandable content feedback from users
3 participants
@mmcallister @ptgott @zmb3