Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating OS Package metadata: license and description #49793

Merged
merged 6 commits into from
Dec 9, 2024
+7 −3
Merged

Updating OS Package metadata: license and description #49793

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9013257
Updating OS Package metadata: license and description
doggydogworld Dec 4, 2024
db8f708
Adding community license to tarball
doggydogworld Dec 5, 2024
db55d27
Updating build-package to include license for OSS package metadata
doggydogworld Dec 5, 2024
58a9179
Fixing some interpolation errors
doggydogworld Dec 6, 2024
09987ea
Removing unecessary line
doggydogworld Dec 6, 2024
4e9b58a
Cleaning up the metadata formatting
doggydogworld Dec 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions build.assets/build-package.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,9 +74,9 @@ FPM_IMAGE_RPM="public.ecr.aws/gravitational/fpm:centos8-1.15.1-1"

# extra package information for linux
MAINTAINER="[email protected]"
LICENSE="Apache-2.0"
LICENSE="AGPL-3.0-or-later"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The packages we distribute are governed by build.assets/LICENSE-community, NOT by AGPLv3.

We should change this (is there a way to use a custom license in a package?), and we should also be including a copy of LICENSE-community in the package itself.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok the task we had wasn't entirely clear on what was necessary. Thanks for the additional context.

We should be able to use a custom license. Afaik this just takes in an arbitrary string. Unfortunately there's not really a way to query for the contents of the license itself. Maybe we could provide a link to the license in the description?

Adding the LICENSE-community should be easy enough though. Just need to update build-archive to include it in the tarball.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose its even a little more complicated than that, as the -ent packages are not governed by LICENSE-community.

VENDOR="Gravitational"
DESCRIPTION="Teleport is a gateway for managing access to clusters of Linux servers via SSH or the Kubernetes API"
DESCRIPTION="Teleport provides on-demand, least-privileged access to your infrastructure, on a foundation of cryptographic identity and zero trust, with built-in identity and policy governance"
DOCS_URL="https://goteleport.com/docs"

# check that curl is installed
Expand Down
Loading