Adds RBAC support for Identity Center Accounts #49808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the purposes of the UI, Identity Center accounts and account
assignments are treated like special Apps. This patch exposes
Account Assignments to the UI via the Unified Resource Cache.
Includes:
- Generating an App resource from an Identity Center Account resource
- General plumbing from backend through to cache and UI
tcsc
added
no-changelog
smallinsky
approved these changes
Dec 5, 2024
smallinsky
approved these changes
Dec 5, 2024
…' into tcsc/idc-expose-accounts-as-apps
tcsc
force-pushed
the
tcsc/idc-account-rbac
branch
2 times, most recently
from
6b9b2b3 to
7fabd53
Compare
- Adds custom RoleMatchers for Identity Center resources - Disables label checking for Identity Center Account resources - Adds custom action checker that understands the generic `KindIdentityCenter` resource kind, and falls back from the requested resource kind to the generic one if not explicitly denied.
tcsc
force-pushed
the
tcsc/idc-account-rbac
branch
from
7fabd53 to
315148b
Compare
r0mant
approved these changes
Dec 5, 2024
public-teleport-github-review-bot
bot
removed request for
ryanclark,
flyinghermit and
doggydogworld
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
tcsc
added a commit
that referenced
this pull request
Dec 10, 2024
Backports #49808 - Adds custom RoleMatchers for Identity Center resources - Disables label checking for Identity Center Account resources - Adds custom action checker that understands the generic `KindIdentityCenter` resource kind, and falls back from the requested resource kind to the generic one if not explicitly denied.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 10, 2024
* [v17] Adds RBAC support for Identity Center Accounts Backports #49808 - Adds custom RoleMatchers for Identity Center resources - Disables label checking for Identity Center Account resources - Adds custom action checker that understands the generic `KindIdentityCenter` resource kind, and falls back from the requested resource kind to the generic one if not explicitly denied. * Update lib/services/role.go Co-authored-by: Sakshyam Shah <[email protected]> --------- Co-authored-by: Sakshyam Shah <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KindIdentityCenterresource kind, and falls back from therequested resource kind to the generic one if not explicitly
denied.