Compute global rollout state #49945
Merged
Compute global rollout state #49945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugoShaka
added
no-changelog
sclevine
approved these changes
Dec 9, 2024
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
vapopov
approved these changes
Dec 9, 2024
tigrato
approved these changes
Dec 9, 2024
public-teleport-github-review-bot
bot
removed request for
espadolini and
EdwardDowling
espadolini
reviewed
Dec 9, 2024
| if groupCount == 0 { | ||
| return autoupdate.AutoUpdateAgentRolloutState_AUTO_UPDATE_AGENT_ROLLOUT_STATE_UNSPECIFIED | ||
| } | ||
|
|
There was a problem hiding this comment.
Please do it something like
Suggested change
| var done, unstarted int | |
| for _, group := range groups { | |
| switch group.State { | |
| case ROLLEDBACK: return ROLLEDBACK | |
| case DONE: done++ | |
| case UNSTARTED: unstarted++ | |
| } | |
| } | |
| if done == groupCount { return DONE } | |
| if unstarted == groupCount { return UNSTARTED } | |
| return ACTIVE | |
| } | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: RFD-184 (although this is not specified in the RFD, during implementation we concluded that it would make cloud's logic easier).
Goal (internal): https://github.com/gravitational/cloud/issues/10289
This PR adds a
autoupdate_agent_rollout.status.statefield summarizing the rollout state.This field will help cloud understand what's the rollout state and if they can update the version.
See example logic in cloud's draft PR (internal): https://github.com/gravitational/cloud/pull/11362/files#diff-599c9d7aefb92d10d6cc7fc837528b5457090c7084e503f23ff0437de8f0f652R66-R70