fix flaky hsm test race #49972
Merged
fix flaky hsm test race #49972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GavinFrazar
added
the
no-changelog
zmb3
approved these changes
Dec 10, 2024
rosstimothy
approved these changes
Dec 10, 2024
public-teleport-github-review-bot
bot
removed request for
marcoandredinis and
nklaassen
marcoandredinis
approved these changes
Dec 10, 2024
|
@GavinFrazar See the table below for backport results.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #47301
TestHSMRevertflakiness #47301I wasn't able to reproduce the data race locally, but I think we just need to wait for the supervisor services to exit, otherwise the auth service heartbeat can fire in one goroutine while we restart the cluster in another goroutine, leading to the data race when we read/write cfg.HostUUID.