ConvertAuditEvent: Set SessionStartEvent.App.IsMultiPort #50008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ravicious
added
no-changelog
This comment was marked as off-topic.
This comment was marked as off-topic.
zmb3
approved these changes
Dec 10, 2024
Joerger
approved these changes
Dec 11, 2024
public-teleport-github-review-bot
bot
removed the request for review
from rosstimothy
ravicious
force-pushed
the
r7s/multi-port-telemetry
branch
from
74a7c3a to
75c814c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it so that when a telemetry event is generated based on the audit event related to an app session, we set
IsMultiPortdepending on whetherTargetPortis present or not. See the Product Usage section of RFD 182.TargetPortis present only when a connection to a TCP app was made using a cert for a multi-port app. That is currently done only when connecting through VNet, but in the future it'll be possible to runtsh proxy app foo-bar --port 1337:<target port>.teleport/lib/srv/app/common/audit.go
Line 122 in cfe482b