[buddy] Fix absence of the Symlinks parameter for Destination when using tbot kube credentials #50370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… kube credentials Signed-off-by: Tim Buckley <[email protected]>
timothyb89
changed the title
zmb3
approved these changes
Dec 18, 2024
marcoandredinis
approved these changes
Dec 18, 2024
public-teleport-github-review-bot
bot
removed request for
strideynet and
fheinecke
strideynet
approved these changes
Dec 18, 2024
|
@timothyb89 See the table below for backport results.
|
mvbrock
pushed a commit
that referenced
this pull request
Dec 19, 2024
… kube credentials (#50370) Signed-off-by: Tim Buckley <[email protected]> Co-authored-by: Vadim Aleksandrov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Buddy PR for #49809
The problem is described in the issue. After the tbot CLI refactoring, the
bot.Destinationobject created for the directory specified in the--destination-dirparameter does not have default values set for theSymlinksattribute.Fixes #49802
Signed-off-by: Tim Buckley [email protected]
changelog: Fix regression in
tboton Linux causing the Kubernetes credential helper to fail