Update awsconfig #50561
Merged
Update awsconfig #50561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GavinFrazar
added
aws
GavinFrazar
force-pushed
the
gavinfrazar/update-awsconfig
branch
3 times, most recently
from
39816e4 to
d280bc5
Compare
greedy52
reviewed
Dec 27, 2024
GavinFrazar
force-pushed
the
gavinfrazar/update-awsconfig
branch
from
d280bc5 to
2bd71db
Compare
GavinFrazar
requested review from
greedy52
and removed request for
ryanclark and
atburke
greedy52
approved these changes
Jan 2, 2025
rosstimothy
approved these changes
Jan 6, 2025
public-teleport-github-review-bot
bot
removed the request for review
from gabrielcorado
* Add a Cache for caching credentials, similar to SDK v1 session cache. * Add a Provider interface that provides aws.Config * Simplified role chaining options Unlike our SDK v1 session cache, the SDK v2 implementation in this PR does not include region as a cache key. There are regional AWS STS endpoints for lower latency calls, but the lowest latency path is to just grab credentials from the cache if we already have them - the region they were originally taken from doesn't matter.
GavinFrazar
force-pushed
the
gavinfrazar/update-awsconfig
branch
from
6cbb81c to
6c11f8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike our SDK v1 session cache, the SDK v2 implementation in this PR does not include region as a cache key.
There are regional AWS STS endpoints for lower latency calls, but the lowest latency path is to just grab credentials from the cache if we already have them - the region they were originally taken from doesn't matter.