Add how to define new endpoints in web for api-versioning.md #50743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avatus
reviewed
Jan 3, 2025
Comment on lines
+174
to
+177
| // TODO(<your-github-handle>): DELETE IN 18.0 - replaced by /v2/webapi/users | ||
| create: '/v1/webapi/users', | ||
| createV2: '/v2/webapi/users', | ||
| } |
There was a problem hiding this comment.
I think we'd only need the verbV2 if we plan on using both (like a fallback for example). Otherwise, the current client should just have the version it plans on using.
So I think this specific pattern is fine, I just don't think we'll be using it too often
avatus
added
the
no-changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@avatus raised a good question on this PR #50472 (comment) that introduces v2 endpoints, about how to move forward with paths that are the same but with differing HTTP verbs.
we used to create a variable with a path defined, but this path can be used for multiple verbs (mostly POST and PUT), which makes it hard to differentiate v2 endpoints