Reduce reliance on servicecfg.Config logrus logger #50817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosstimothy
added
the
no-changelog
rosstimothy
force-pushed
the
tross/config_slog
branch
2 times, most recently
from
2ad2f6a to
55173a4
Compare
Converts most items to use servicecfg.Config.Logger instead of servicecfg.Config.Log. The deprecated logrus logger unfortunately cannot be removed yet as it's still used in e. Additionally all logging within the config package was converted to use slog.
rosstimothy
force-pushed
the
tross/config_slog
branch
from
55173a4 to
3a6dea2
Compare
github-actions
bot
requested review from
hugoShaka,
marcoandredinis,
nklaassen and
tigrato
marcoandredinis
approved these changes
Jan 7, 2025
codingllama
approved these changes
Jan 7, 2025
public-teleport-github-review-bot
bot
removed request for
tigrato,
hugoShaka and
nklaassen
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts most items to use servicecfg.Config.Logger instead of servicecfg.Config.Log. The deprecated logrus logger unfortunately cannot be removed yet as it's still used in e. Additionally all logging within the config package was converted to use slog.