Remove direct zap dependecy in operator and kube-agent-updater #50960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugoShaka
changed the title
rosstimothy
approved these changes
Jan 10, 2025
integrations/kube-agent-updater/cmd/teleport-kube-agent-updater/main.go
Outdated
Show resolved
Hide resolved
Co-authored-by: rosstimothy <[email protected]>
marcoandredinis
approved these changes
Jan 13, 2025
public-teleport-github-review-bot
bot
removed the request for review
from tigrato
tigrato
approved these changes
Jan 13, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
mvbrock
pushed a commit
that referenced
this pull request
Jan 18, 2025
* Remove direct zap dependecy * fixup! Remove direct zap dependecy * Apply suggestions from code review Co-authored-by: rosstimothy <[email protected]> --------- Co-authored-by: rosstimothy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the direct zap dependency from the operator and kube-agent-updater.
This is a breaking change and must not be backported as the
-zap-*CLI flags are removed. Those flags were not documented nor used directly, but users might have set them via theextraArgschart value.I switched logs by default to JSON and did not add a --log-format flag. I add such flag if you think this is necessary.
Changelog: Remove the
zap-log-level,zap-devel,zap-encoderandzap-stacktrace-levelflags in the operator. Use--log-levelinstead.Changelog: Remove the
zap-log-level,zap-devel,zap-encoderandzap-stacktrace-levelflags in the teleport-kube-agent-updater. Use--log-levelinstead.Changelog: The operator now logs using JSON by default.
Changelog: The kube-agent-updater now logs using JSON by default.