-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workload Identity: workload-identity-jwt
#51027
Merged
strideynet
merged 8 commits into
master
from
strideynet/tbot-workload-identity-jwt-output
Jan 17, 2025
Merged
Workload Identity: workload-identity-jwt
#51027
strideynet
merged 8 commits into
master
from
strideynet/tbot-workload-identity-jwt-output
Jan 17, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strideynet
force-pushed
the
strideynet/tbot-workload-api-new-ux
branch
from
January 15, 2025 14:06
65cd987
to
b426d09
Compare
strideynet
force-pushed
the
strideynet/tbot-workload-identity-jwt-output
branch
from
January 15, 2025 15:05
2e13610
to
11507a7
Compare
strideynet
added
no-changelog
Indicates that a PR does not require a changelog entry
backport/branch/v16
backport/branch/v17
labels
Jan 16, 2025
bernardjkim
approved these changes
Jan 16, 2025
timothyb89
approved these changes
Jan 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working well on my machine, and the JWTs decode as expected:
$ tbot start workload-identity-jwt --join-method=token --token=foo --proxy-server=example.teleport.sh:443 --name-selector my-workload-identity --storage=./tbot-storage --destination=./tbot-user --audience=foo --audience="bar" --oneshot; cat ./tbot-user/jwt_svid | jwt decode -
[...snip...]
Token claims
------------
{
"aud": [
"foo",
"bar"
],
"exp": 1737087066,
"iat": 1737083466,
"iss": "https://example.teleport.sh/workload-identity",
"jti": "b0d215ad510516abefd057889a6420a9",
"sub": "spiffe://example.teleport.sh/my/awesome/identity"
}
Base automatically changed from
strideynet/tbot-workload-api-new-ux
to
master
January 17, 2025 11:02
strideynet
force-pushed
the
strideynet/tbot-workload-identity-jwt-output
branch
from
January 17, 2025 11:16
3828eaa
to
f8d8ab4
Compare
@strideynet See the table below for backport results.
|
strideynet
added a commit
that referenced
this pull request
Jan 17, 2025
* Add config.WorkloadIdentityJWTService * Add tsests for WorkloadIdentityJWTService * Add CLI setup for `workload-identity-jwt` svc * Start work on svc implementation * Add TestBotWorkloadIdentityJWT * Correct log message * Firm up TestBotWorkloadIdentityX509 test * Fix param names in errors
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 17, 2025
* Workload Identity: `workload-identity-jwt` (#51027) * Add config.WorkloadIdentityJWTService * Add tsests for WorkloadIdentityJWTService * Add CLI setup for `workload-identity-jwt` svc * Start work on svc implementation * Add TestBotWorkloadIdentityJWT * Correct log message * Firm up TestBotWorkloadIdentityX509 test * Fix param names in errors * Fix jitter in backport
mvbrock
pushed a commit
that referenced
this pull request
Jan 18, 2025
* Add config.WorkloadIdentityJWTService * Add tsests for WorkloadIdentityJWTService * Add CLI setup for `workload-identity-jwt` svc * Start work on svc implementation * Add TestBotWorkloadIdentityJWT * Correct log message * Firm up TestBotWorkloadIdentityX509 test * Fix param names in errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport/branch/v16
backport/branch/v17
machine-id
no-changelog
Indicates that a PR does not require a changelog entry
size/lg
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #48814
Closes #49986
As per RFD191: #49133
Depends on #50859
Adds the final new service,
workload-identity-jwt
. No change-log as this will be published when the feature flag is removed.