refactor: code clean up #66
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guillaumelamirand
force-pushed
the
apim-6749-code-cleanup
branch
from
cd8a3f3 to
499fc4a
Compare
phiz71
approved these changes
Oct 3, 2024
| } | ||
|
|
||
| public void setWhitelistIps(List<String> whitelistIps) { | ||
| this.whitelistIps = whitelistIps == null ? List.of() : whitelistIps.stream().map(String::trim).collect(Collectors.toList()); |
There was a problem hiding this comment.
Should we use this implementation instead of the Lombok generated one?
| } | ||
|
|
||
| public void setBlacklistIps(List<String> blacklistIps) { | ||
| this.blacklistIps = blacklistIps == null ? List.of() : blacklistIps.stream().map(String::trim).collect(Collectors.toList()); |
There was a problem hiding this comment.
Should we use this implementation instead of the Lombok generated one?
| } | ||
|
|
||
| public LookupIpVersion getLookupIpVersion() { | ||
| return lookupIpVersion == null ? LookupIpVersion.ALL : lookupIpVersion; |
There was a problem hiding this comment.
Should we use this implementation instead of the Lombok generated one?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
https://gravitee.atlassian.net/browse/APIM-6749
Description
At the end, nothing to fix but I had already done some clean up...
Additional context
Gravitee.io Automatic Deployment
🚀 A prerelease version of this package has been published on Gravitee's private artifactory, you can:
1.14.0