Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rendering for highway=busway #4385

Closed
wants to merge 2 commits into from

Conversation

kolgza
Copy link
Contributor

@kolgza kolgza commented Apr 23, 2021

This is basically the same pull request as #4382, except from a different branch. In other words, I don't know how to use git. @imagico: please request the same changes as before.


Fixes # (id of the issue to be closed)

Changes proposed in this pull request:

The rendering for higway=bus_guideway would be applied to instances of highway=busway.

Test rendering with links to the example places:

Before

image

After

image

Copy link
Collaborator

@imagico imagico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments on #4382.

I am not opposed to the idea of rendering bus only roads built and used for specific bus routes in a distinct fashion. But i don't think the tag highway=busway has shown clear enough adoption and consistency in use by mappers to support rendering it here and i don't think the suggested rendering (in particular the blue color) is a good choice for that - in particular also where these roads connect to the general road network. That is different for bus_guideway - which is more rail like and does not transit to regular roads.

@kolgza
Copy link
Contributor Author

kolgza commented Apr 23, 2021

i don't think the suggested rendering (in particular the blue color) is a good choice for that

This relates to #3396

@kolgza
Copy link
Contributor Author

kolgza commented Apr 23, 2021

That is different for bus_guideway - which […] does not transition to regular roads.

Here is a counterexample:
image
image

This issue is inherent to the fact that highway=bus_guideway is rendered like a railway, but must somehow merge into roads.
@pnorman discussed both redoing the rendering for bus guideways, and unifying it with highway=busway.

@imagico
Copy link
Collaborator

imagico commented Apr 26, 2021

Also keep in mind #3581 - the rendering of highway=bus_guideway currently suffers from various issues related to layering relative to other roads features. It would not be advisable to extend this highly suboptimal rendering to additional features without addressing those issues first.

@kolgza
Copy link
Contributor Author

kolgza commented Apr 26, 2021

Closing, because I lack the expertise to implement this.

@kolgza kolgza closed this Apr 26, 2021
@kolgza kolgza deleted the busway_render branch April 27, 2021 15:06
@kolgza kolgza restored the busway_render branch April 27, 2021 15:06
@kolgza kolgza deleted the busway_render branch April 27, 2021 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants