Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rendering specific access tags #4952

Merged
merged 19 commits into from
Oct 16, 2024
Merged

Rendering specific access tags #4952

merged 19 commits into from
Oct 16, 2024

Commits on Apr 12, 2024

  1. Interpret additional access tags 

    mode specific access tags relevant to primary mode of highway interpreted to determine access marking for:
Road types (motorcar > motor_vehicle > vehicle)
Footway (foot)
Cycleway (bicycle)
Bridleway (horse)
    @dch0ph
    dch0ph committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    f8488d2 View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2024

  1. Function load in CI

    @dch0ph
    dch0ph committed Apr 13, 2024
    Configuration menu
    Copy the full SHA
    9c8098b View commit details
    Browse the repository at this point in the history

  2. Add carto_path_primary_path

    @dch0ph
    dch0ph committed Apr 13, 2024
    Configuration menu
    Copy the full SHA
    a413991 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2024

  1. Moving customers, permit 

    Following discussion moving:
access=customers -> "restricted" marking
access=permit -> "no" marking
    @dch0ph
    dch0ph committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    911569e View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2024

  1. Major changes in response to comments 

    Functions renamed for clarity

Changed logic for mode-specific tags, only ignoring 'unknown' values

unknown access type return for unknown/uninterpretable

path promoted to cycleway/bridleway in SQL rather than MSS
    @dch0ph
    dch0ph committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    8f386d2 View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2024

  1. Use foot primary mode for highway=pedestrian

    @dch0ph
    dch0ph committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    e04589c View commit details
    Browse the repository at this point in the history

Commits on May 1, 2024

  1. Typo fix

    @dch0ph
    dch0ph committed May 1, 2024
    Configuration menu
    Copy the full SHA
    a300250 View commit details
    Browse the repository at this point in the history

  2. Remove incorrect END statements

    @dch0ph
    dch0ph committed May 1, 2024
    Configuration menu
    Copy the full SHA
    8f92b8d View commit details
    Browse the repository at this point in the history

Commits on May 4, 2024

  1. Fix regression on introducing explicit unknown

    @dch0ph
    dch0ph committed May 4, 2024
    Configuration menu
    Copy the full SHA
    42a9e75 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. Fix regression for highway=path

    @dch0ph
    dch0ph committed May 7, 2024
    Configuration menu
    Copy the full SHA
    f99920e View commit details
    Browse the repository at this point in the history

Commits on May 10, 2024

  1. Alter 'destination' outcome for 2-state access 

    'destination' on path / footway etc. interpreted as 'yes' (matching current behaviour)
    @dch0ph
    dch0ph committed May 10, 2024
    Configuration menu
    Copy the full SHA
    cdc9ace View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2024

  1. Merge remote-tracking branch 'upstream/master' into carto-new-access

    @dch0ph
    dch0ph committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    987258c View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2024

  1. Simplify functions.sql 

    Reduce number of functions
Tidy comments
    @dch0ph
    dch0ph committed Jun 15, 2024
    Configuration menu
    Copy the full SHA
    a1dfd94 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2024

  1. Tidy access functions 

    Consistent formatting of CASE/WHEN
Use more idiomatic COALESCE(NULLIF(...),)
    @dch0ph
    dch0ph committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    194d641 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2024

  1. Update functions.sql 

    Change argument name accesstag -> accessvalue
Improve documentation
Simplify logic for promoted paths
    @dch0ph
    dch0ph committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    c4c775c View commit details
    Browse the repository at this point in the history

  2. Remove obsolete comment from MML

    @dch0ph
    dch0ph committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    15c75d6 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2024

  1. Avoid unknown overload 

    Return "unrecognised" rather than "unknown" if access restriction is not one of recognised values
    @dch0ph
    dch0ph committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    1d369dc View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2024

  1. Extend code comments 

    Note on short-circuiting logic in carto_highway_int_access
    @dch0ph
    dch0ph committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    b1f77c2 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2024

  1. Fix broken bridge on path 

    Bridge not being rendered on highway=path
    @dch0ph
    dch0ph committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    af8400a View commit details
    Browse the repository at this point in the history