Skip to content

Commit

Permalink
Do not manually close a pull request
Browse files Browse the repository at this point in the history
Because of the manual closing, the pull request is occasionally set to
"closed" rather than "merged" even though it was successful. This is
because there is a little latency between the fast-forwarding and the
automatic transition to "merged".

If a bad thing happens, it would be better to leave it "open".
  • Loading branch information
barosl committed Dec 15, 2014
1 parent 8a40722 commit 5a1a6b6
Showing 1 changed file with 0 additions and 7 deletions.
7 changes: 0 additions & 7 deletions bors.py
Original file line number Diff line number Diff line change
Expand Up @@ -597,13 +597,6 @@ def advance_master_ref_to_test(self, pulls):
self.add_comment(self.sha, s)
self.set_error(s)

try:
self.dst().pulls(self.num).patch(state="closed")
self.closed = True
except github.ApiError:
self.log.info("closing failed; auto-closed after merge?")
pass

return ret

def try_advance(self, pulls, cfg):
Expand Down

0 comments on commit 5a1a6b6

Please sign in to comment.