Rollup fixes #48
Merged
Rollup fixes #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @brson |
|
As bors now caches commit IDs in the comments, some GitHub API calls could be eliminated. However, you should |
|
More changes here:
|
barosl
force-pushed
the
rollup-fixes
branch
4 times, most recently
from
c7b0b8e to
351ed7a
Compare
Basically, we can skip the TESTED state entirely. We can also check the next pull request at the same time. Fixes graydon#35.
Because of the manual closing, the pull request is occasionally set to "closed" rather than "merged" even though it was successful. This is because there is a little latency between the fast-forwarding and the automatic transition to "merged". If a bad thing happens, it would be better to leave it "open".
r+, r=me, r=[name], r-, and retry are checked more generously.
|
I'm just going to merge this and hope it works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes summary: