Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jeweler for next release #66

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tessie
Copy link
Collaborator

@tessie tessie commented Oct 20, 2017

No description provided.

@tessie
Copy link
Collaborator Author

tessie commented Oct 24, 2017

@joschi I was trying to update the gem and then noticed that rake version etc was giving error

NoMethodError: undefined method dependencies_for' for #Bundler::Runtime:0x007fcc140f96e0
Did you mean? dependencies
/Users/tessy/.rvm/gems/ruby-2.4.1/gems/jeweler-2.1.1/lib/jeweler/specification.rb:73:in block in set_jeweler_defaults' /Users/tessy/.rvm/gems/ruby-2.4.1/gems/jeweler-2.1.1/lib/jeweler/specification.rb:41:in chdir'
/Users/tessy/.rvm/gems/ruby-2.4.1/gems/jeweler-2.1.1/lib/jeweler/specification.rb:41:in set_jeweler_defaults' /Users/tessy/.rvm/gems/ruby-2.4.1/gems/jeweler-2.1.1/lib/jeweler.rb:37:in initialize'
/Users/tessy/.rvm/gems/ruby-2.4.1/gems/jeweler-2.1.1/lib/jeweler/tasks.rb:52:in new' /Users/tessy/.rvm/gems/ruby-2.4.1/gems/jeweler-2.1.1/lib/jeweler/tasks.rb:52:in jeweler'
/Users/tessy/.rvm/gems/ruby-2.4.1/gems/jeweler-2.1.1/lib/jeweler/tasks.rb:82:in block in define' /Users/tessy/.rvm/gems/ruby-2.4.1/gems/rake-12.1.0/exe/rake:27:in <top (required)>'
/Users/tessy/.rvm/gems/ruby-2.4.1/bin/ruby_executable_hooks:15:in eval' /Users/tessy/.rvm/gems/ruby-2.4.1/bin/ruby_executable_hooks:15:in

'`

But now it showing a warning with nokogiri. I think this could be merged .Once this is done I could do the jeweler release. I tried fixing it. Updating nokogiri to the latest version would break older ruby versions. Let me know know your suggestions

@milgner
Copy link
Contributor

milgner commented Mar 18, 2018

@tessie first things first: thank you for helping out! I'm really sorry I've been so unresponsive for so long, will try becoming more involved if necessary.

As for breaking compatibility with older versions, I think there are still people out there being stuck on Ruby 1.9. What do you think about making one last release with 1.9 support and then dropping support for pre-2.1 rubies?

@CLAassistant
Copy link

CLAassistant commented Sep 17, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants