-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a shim header to support locking without ldrex/strex #1517
Conversation
Required to allow the USB queue code to be built for the M0.
34e9458
to
b9945de
Compare
Hello again :) Sorry to bug you with this, but to achieve this goal, it would be great if you could also change the nvic.h include to dispatch ;) Thanks for all the help! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor concern I have is about the side-effects of using one of the functions on their own (and leaving interrupts disabled for example) but, given that ldrex/strex must be used in a pair, I'm ok with assuming that for these functions too. I think it'd be worth adding a comment to that effect though.
Both changes made. |
Thanks a lot :-) |
Back from testing.
Or maybe you prefer the version with the "memory" clobber ?
|
Required to allow the USB queue code to be built for the M0.