Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation logic added #44

Merged
merged 13 commits into from
Jan 14, 2024
Merged

Translation logic added #44

merged 13 commits into from
Jan 14, 2024

Conversation

ArneTR
Copy link
Member

@ArneTR ArneTR commented Jan 11, 2024

All the information how to use are in the README

@ArneTR
Copy link
Member Author

ArneTR commented Jan 11, 2024

One note: The language switcher is provisionary. I will integrate a sleeker one, once the translation is complete and we know how big the german menu will be

@ribalba
Copy link
Member

ribalba commented Jan 14, 2024

There is a problem with the menu:

        <option value="{{ absLangURL "/" }}#nav-events" class="second_item">{{i18n "talks"}}</option>
and
        <option value="{{ absLangURL "/" }}#nav-team" class="second_item">{{i18n "team"}}</option>

Is not shown?

Also clicking on the logo will always return to the English version.

@ArneTR
Copy link
Member Author

ArneTR commented Jan 14, 2024

  • The home logo link is now language aware. Nice find!

  • The menu issue I cannot reproduce. Maybe you expect something else? The option listings are for the mobile view and will not show on desktop. Did you take that into account? The desktop menu is less populated as we do not have enough space

@ArneTR ArneTR marked this pull request as ready for review January 14, 2024 17:43
@ArneTR ArneTR merged commit 394e3ec into main Jan 14, 2024
0 of 2 checks passed
@ArneTR ArneTR deleted the translation branch January 14, 2024 17:43
ArneTR added a commit that referenced this pull request Jan 30, 2024
* main: (43 commits)
  Fixed 404 links
  Added accso slides
  Typo
  Removes the deepl check
  Ignores the .github folder in workflow (#46)
  References more compact
  Adds a blog article about png2webp (#43)
  Update mannheim-business-school-2023-01-17.md
  Translation fix
  Removed DE event list
  Translation logic added (#44)
  Typo
  Added new Meetups
  Changed TGWF image to green-coding.io and removed white line in footer (#45)
  All the pngs to webps (#42)
  Better wording in chart
  Unit Joules added
  Name change in imprint
  Moved domain from .berlin to .io (#41)
  Added dynamic social media images + CPU Power capping image (#40)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants