Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

edit figure captions #11

Merged
merged 7 commits into from
Jan 17, 2020
Merged

edit figure captions #11

merged 7 commits into from
Jan 17, 2020

Conversation

trangdata
Copy link
Collaborator

No description provided.

cgreene
cgreene reviewed Jan 17, 2020
View reviewed changes
Copy link
Member

@cgreene cgreene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if this is ready for review yet but just a few things i noticed when scanning it

content/20.results.md Outdated Show resolved Hide resolved
content/20.results.md Outdated
![Estimated proportion of gender prediction over the years of all Pubmed journal authors (A),
of all ISCB fellows and keynote speakers (B),
and of ISCB honorees in each honor category (C).
![Estimated composition of gender prediction over the years of
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I read papers I really like it if the first line of a figure legend is the take-home point of the figure. If the reader takes away only one thing from this figure, what should it be?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a great point! I made adjustments, let me know what you think!

content/20.results.md Outdated
A higher proportion of individuals who had last names associated with selecting white as a race/ethnicity category in the US census were ISCB honorees (Fig. {@fig:racial_makeup}C) than authors (Fig. {@fig:racial_makeup}A).
Separating honoree results by honor category did not reveal any clear differences (Fig. {@fig:racial_makeup}D).

![Estimated composition of census-based race/ethnicity prediction over the years of
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above re: take-home point

cgreene
cgreene approved these changes Jan 17, 2020
View reviewed changes
Copy link
Member

@cgreene cgreene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more small suggestion but looks good to me. I'm also happy to wait if you had more changes you want to make.

content/20.results.md Outdated Show resolved Hide resolved
@trangdata
Copy link
Collaborator Author

trangdata commented Jan 17, 2020 •
edited
Loading

One more small suggestion but looks good to me. I'm also happy to wait if you had more changes you want to make.

I wanted to add a few more citations but am a bit slow at finding the place to do so. Any suggestions?

EDIT: Clarification: I don't want to break the focus we have in the intro on invited speakers. Perhaps first paragraph of Conclusion?

@cgreene
Copy link
Member

cgreene commented Jan 17, 2020

I feel like those are helpful for caveats of the work. We're making a lot of assumptions about "the field" being last authors or corresponding ones. If that assumption is incorrect or already biased, we might be undercounting women in the field. I think it could go with either caveats around where we write about our selection of last/corresponding author to estimate the field or in the conclusion.

cgreene
cgreene approved these changes Jan 17, 2020
View reviewed changes
Copy link
Member

@cgreene cgreene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See what you think of my framing of the first sentence. I feel like we don't quite have the data to say if women are over/under represented relative to the field in the corresponding position.

content/30.conclusions.md Outdated Show resolved Hide resolved
content/30.conclusions.md Outdated Show resolved Hide resolved
trangdata and others added 2 commits January 17, 2020 15:36
@trangdata @cgreene
emphasizing
3952d8a 
Co-Authored-By: Casey Greene <[email protected]>
@trangdata @cgreene
phrasing
14de448 
Co-Authored-By: Casey Greene <[email protected]>
@trangdata trangdata merged commit 1071cf5 into master Jan 17, 2020
@trangdata trangdata deleted the trang-edits branch January 17, 2020 23:07
dhimmel pushed a commit that referenced this pull request Jan 17, 2020
@trangdata
Merge pull request #11 from greenelab/trang-edits [ci skip]
8dc9ef4 
This build is based on
1071cf5.

This commit was created by the following CI build and job:
https://github.com/greenelab/iscb-diversity-manuscript/commit/1071cf5e939ebf187fd53b55d7e7438adbe548cc/checks
https://github.com/greenelab/iscb-diversity-manuscript/runs/run2

The full commit message that triggered this build is copied below:

Merge pull request #11 from greenelab/trang-edits

edit figure captions
dhimmel pushed a commit that referenced this pull request Jan 17, 2020
@trangdata
Merge pull request #11 from greenelab/trang-edits [ci skip]
cad222d 
This build is based on
1071cf5.

This commit was created by the following CI build and job:
https://github.com/greenelab/iscb-diversity-manuscript/commit/1071cf5e939ebf187fd53b55d7e7438adbe548cc/checks
https://github.com/greenelab/iscb-diversity-manuscript/runs/run2

The full commit message that triggered this build is copied below:

Merge pull request #11 from greenelab/trang-edits

edit figure captions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgreene cgreene cgreene approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trangdata @cgreene