Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PLANET-7418 Implement Post type filter for News & Stories page #2218

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

PLANET-7418 Implement Post type filter for News & Stories page #2218

wants to merge 1 commit into from

Conversation

mleray
Copy link
Contributor

@mleray mleray commented Feb 16, 2024 •
edited
Loading

Description

See PLANET-7418

I have 2 questions left regarding this implementation:

  • How should we handle pagination? For now there is none, all posts are shown on the page which might take forever to load and be way too long in most sites 😕 We could rebuild the query loop pagination from scratch, but that would take some time
  • How do we want to handle posts with several post types, since we only show one in the listing page? I started a conversation about this on Slack

Testing

You can check out the News & Stories page on local or on the titan test instance.

@mleray mleray self-assigned this Feb 16, 2024
@mleray mleray force-pushed the news-and-stories-post-type-filter branch 2 times, most recently from bf57d54 to 06eabb0 Compare February 16, 2024 14:40
planet-4 added a commit to greenpeace/planet4-test-titan that referenced this pull request Feb 16, 2024
@planet-4
greenpeace/planet4-master-theme#2218 at 06eabb00
39ec050 
/unhold 73907443-f63b-427a-9d3e-2737011ec1ee
@planet-4
Copy link
Contributor

planet-4 commented Feb 16, 2024 •
edited
Loading

Test instance is ready 🚀

🌑 titan | admin | blocks report | CircleCI | composer-local.json

⌚ 2024.02.27 09:02:21

@mleray mleray force-pushed the news-and-stories-post-type-filter branch from 06eabb0 to ddeb992 Compare February 16, 2024 15:50
planet-4 added a commit to greenpeace/planet4-test-titan that referenced this pull request Feb 16, 2024
@planet-4
greenpeace/planet4-master-theme#2218 at ddeb992c
a75ac26 
/unhold 1dedb2cc-d252-4a14-a7c1-76c5e2fa0830
@mleray mleray force-pushed the news-and-stories-post-type-filter branch from ddeb992 to 20703d4 Compare February 16, 2024 16:17
planet-4 added a commit to greenpeace/planet4-test-titan that referenced this pull request Feb 16, 2024
@planet-4
greenpeace/planet4-master-theme#2218 at 20703d45
47336bd 
/unhold 7b16624b-0533-4711-a0e8-d777d86c6ce3
@mleray mleray force-pushed the news-and-stories-post-type-filter branch from 20703d4 to bb648e4 Compare February 16, 2024 17:16
planet-4 added a commit to greenpeace/planet4-test-titan that referenced this pull request Feb 16, 2024
@planet-4
greenpeace/planet4-master-theme#2218 at bb648e4e
f95c1af 
/unhold ae7a5cf0-17c0-4b82-a73f-f7f8832fd6f2
@mleray mleray force-pushed the news-and-stories-post-type-filter branch 2 times, most recently from 723853c to 4128e48 Compare February 19, 2024 16:26
planet-4 added a commit to greenpeace/planet4-test-titan that referenced this pull request Feb 19, 2024
@planet-4
greenpeace/planet4-master-theme#2218 at 4128e483
d17e65c 
/unhold 143ca90c-1554-465c-93ee-f56a022c140d
@mleray mleray force-pushed the news-and-stories-post-type-filter branch from 4128e48 to ba2a958 Compare February 20, 2024 09:01
planet-4 added a commit to greenpeace/planet4-test-titan that referenced this pull request Feb 20, 2024
@planet-4
greenpeace/planet4-master-theme#2218 at ba2a958c
3bced32 
/unhold 06f791a8-7c65-4cc5-b112-edcb4aaf5797
@mleray mleray force-pushed the news-and-stories-post-type-filter branch from ba2a958 to 0a74e79 Compare February 22, 2024 08:58
planet-4 added a commit to greenpeace/planet4-test-titan that referenced this pull request Feb 22, 2024
@planet-4
greenpeace/planet4-master-theme#2218 at 0a74e79c
f496c1a 
/unhold ed3cd450-fb82-4a59-a1e1-92841cce1775
@mleray mleray force-pushed the news-and-stories-post-type-filter branch from 0a74e79 to 5bd6dbf Compare February 22, 2024 12:47
planet-4 added a commit to greenpeace/planet4-test-titan that referenced this pull request Feb 22, 2024
@planet-4
greenpeace/planet4-master-theme#2218 at 5bd6dbff
3857b92 
/unhold 40abc43f-f9ce-49f6-9894-41aee5665530
@mleray mleray force-pushed the news-and-stories-post-type-filter branch from 5bd6dbf to e6acaf5 Compare February 26, 2024 10:49
planet-4 added a commit to greenpeace/planet4-test-titan that referenced this pull request Feb 26, 2024
@planet-4
greenpeace/planet4-master-theme#2218 at e6acaf51
aee450a 
/unhold 236b8630-69a2-4c2c-87ff-37b55d078909
@mleray mleray force-pushed the news-and-stories-post-type-filter branch from e6acaf5 to 381bf4f Compare February 26, 2024 11:18
planet-4 added a commit to greenpeace/planet4-test-titan that referenced this pull request Feb 26, 2024
@planet-4
greenpeace/planet4-master-theme#2218 at 381bf4f4
183b84a 
/unhold cd1cff0d-7bdc-4a72-896b-cddcb2184389
@mleray mleray force-pushed the news-and-stories-post-type-filter branch from 381bf4f to ae0ffe1 Compare February 26, 2024 13:12
planet-4 added a commit to greenpeace/planet4-test-titan that referenced this pull request Feb 26, 2024
@planet-4
greenpeace/planet4-master-theme#2218 at ae0ffe12
4f48270 
/unhold d374b864-4b2c-4d9f-9bac-627c7a15e832
@mleray mleray force-pushed the news-and-stories-post-type-filter branch from ae0ffe1 to e3e6d32 Compare February 26, 2024 13:42
planet-4 added a commit to greenpeace/planet4-test-titan that referenced this pull request Feb 26, 2024
@planet-4
greenpeace/planet4-master-theme#2218 at e3e6d322
488936a 
/unhold 896c59b9-7909-4b9a-9d18-1bca674ed460
@mleray mleray force-pushed the news-and-stories-post-type-filter branch from e3e6d32 to 7561fee Compare February 26, 2024 14:28
planet-4 added a commit to greenpeace/planet4-test-titan that referenced this pull request Feb 26, 2024
@planet-4
greenpeace/planet4-master-theme#2218 at 7561fee8
9346404 
/unhold ea3c779b-4f51-48a2-b821-562358ca54fa
@mleray mleray force-pushed the news-and-stories-post-type-filter branch from 7561fee to 874395f Compare February 26, 2024 14:33
planet-4 added a commit to greenpeace/planet4-test-titan that referenced this pull request Feb 26, 2024
@planet-4
greenpeace/planet4-master-theme#2218 at 874395f0
16b90ad 
/unhold f1a4700f-727c-4e00-88d5-bd65a797e1e9
@mleray mleray force-pushed the news-and-stories-post-type-filter branch from 874395f to d49a048 Compare February 27, 2024 08:53
planet-4 added a commit to greenpeace/planet4-test-titan that referenced this pull request Feb 27, 2024
@planet-4
greenpeace/planet4-master-theme#2218 at d49a0480
d8af9bd 
/unhold 94182333-b037-451a-bdf8-f2f4fb79a625
@mleray mleray added the Review label Feb 27, 2024
@mleray mleray marked this pull request as ready for review February 27, 2024 08:57
@mleray mleray added UAT Needed This PR requires User Acceptance Tests before merge DO NOT MERGE and removed Review labels Feb 27, 2024
planet-4 added a commit to greenpeace/planet4-test-titan that referenced this pull request Nov 4, 2024
@planet-4
greenpeace/planet4-master-theme#2218 at e1b16b88
9b1f35f 
/unhold 27e95511-1798-439a-a6fa-1c6b3e3c4294
@mleray mleray force-pushed the news-and-stories-post-type-filter branch from e1b16b8 to d49a048 Compare November 4, 2024 13:40
planet-4 added a commit to greenpeace/planet4-test-titan that referenced this pull request Nov 4, 2024
@planet-4
greenpeace/planet4-master-theme#2218 at d49a0480
9bcc7ff 
/unhold 36d88ea8-8e97-4b12-b302-9e855860a3d1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@comzeradd comzeradd Awaiting requested review from comzeradd

@Osong-Michael Osong-Michael Awaiting requested review from Osong-Michael

At least 1 approving review is required to merge this pull request.

Assignees

@mleray mleray

Labels
DO NOT MERGE [Test Env] titan UAT Needed This PR requires User Acceptance Tests before merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mleray @planet-4