PLANET-7519: Guestbook block refactoring to block.json #2286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ref: https://jira.greenpeace.org/browse/PLANET-7519 This is a demo for block refactoring, following Gutenberg structure. It allows WordPress to handle assets loading automatically. This PR has multiple issues, due to the packages and webpack versions being a lot older than what Gutenberg currently uses. In particular, we can't update wordpress/scripts higher because of PostCss package, npm version, webpack version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: https://jira.greenpeace.org/browse/PLANET-7519
This is a demo for block refactoring, following Gutenberg structure. It allows WordPress to handle assets loading automatically.
This PR has multiple issues, due to the packages and webpack versions being a lot older than what Gutenberg currently uses. In particular, we can't update wordpress/scripts higher because of npm version and webpack version.
As a hack, we copy some functions from the scripts package in a specific webpack config file dedicated to those blocks.
We also attempt to make the main webpack config independent of wordpress/scripts, to try help with future packages/webpack updates
Load blocks in PHP using
Blocks\Register::registerFromAssets('foldername');Run
npm run build:blocksto build blocks converted to block.json structure.Assets are loaded automatically by WordPress when it detects a block in content.
To test Guestbook locally, run the npm block command, disable the planet4-gutenberg-blocks plugin, use a Guestbook block and check that:
assets/build/blocks/guestbook/index.jsassets/build/blocks/guestbook/viewScripts.jsCf. documentation for autoloaded scripts