PLANET-7660: Fix checkbox mark alignement #2441
Open
+11
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
planet-4
added a commit
to greenpeace/planet4-test-rhea
that referenced
this pull request
Nov 14, 2024
/unhold 359683c9-1016-4e78-adfa-083712c6cf29
Test instance is ready 🚀🌑 rhea | admin | blocks report | CircleCI | composer-local.json ⌚ 2024.11.15 07:46:33 |
GP-Dan-Tovbein
requested review from
a team,
sagarsdeshmukh and
mardelnet
and removed request for
a team
GP-Dan-Tovbein
commented
Nov 14, 2024
| @@ -6,6 +6,9 @@ $large-width: 992px; | |||
| $extra-large-width: 1200px; | |||
| $extra-extra-large-width: 1600px; | |||
|
|
|||
| // Override html selectors | |||
| $checkbox-size: 20px; | |||
There was a problem hiding this comment.
Using this value as variable since it's being used in both files. It will avoid to hve conflict with sizes.
GP-Dan-Tovbein
force-pushed
the
PLANET-7660_fix-checkbox-mark-alignment
branch
from
a21859f
to
b85ea4a
Compare
planet-4
added a commit
to greenpeace/planet4-test-rhea
that referenced
this pull request
Nov 14, 2024
/unhold 72f9d0f7-6e75-4317-a1b0-c20b44c1841e
planet-4
added a commit
to greenpeace/planet4-test-rhea
that referenced
this pull request
Nov 15, 2024
/unhold bd96f132-d795-49c1-ae0f-57c6747fa3b3
mleray
reviewed
Nov 15, 2024
There was a problem hiding this comment.
The issue isn't solved on the Search page, and also not in the form that I've added to your test page. It also still looks broken if the comments checkbox label is only one line long:
mardelnet
reviewed
Nov 15, 2024
There was a problem hiding this comment.
@GP-Dan-Tovbein, in the testing instance I see well the checkbox in the comments box, but not in the form:
|
Thanks both! I've just noticed that the issue is fixed where the text is 2 lines. We need to be sure that it might works for N lines |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: https://jira.greenpeace.org/browse/PLANET-7660
Testing
Navigate through this page and click on "I agree on providing my name, email and content so that my comment can be stored and displayed in the website." checkbox. The mark should be correctly aligned.