PLANET-7731 Add JS strings translation support for blocks plugin strings #2499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sagarsdeshmukh
force-pushed
the
PLANET-7731-JS-translation-bk-strings
branch
from
ccd0569 to
edec921
Compare
planet-4
added a commit
to greenpeace/planet4-test-janus
that referenced
this pull request
Jan 16, 2025
/unhold a23eeeec-f1c8-4adf-a2d9-f0159b127128
Test instance is ready 🚀🌑 janus | admin | blocks report | CircleCI | composer-local.json ⌚ 2025.01.16 10:18:20 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref. https://jira.greenpeace.org/browse/PLANET-7731
Summary
Move javascript files strings translation logic for blocks plugin to master theme.
The JSON files are generated in the handbook and pushed to the master theme's language folder.
Ref:
Related PR
Testing
TBD