Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add composition api, typescript, vue and vuex as peer dependencies. #51

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

HIMISOCOOL
Copy link

add composition api, typescript, vue and vuex as peer dependencies.
marked typescript as optional.

Copy link
Contributor

@davidmeirlevy davidmeirlevy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi!

Thanks again!

this is very risky because the composition API for vue 2 is a beta package and its versions are problematic.
also, the lin can work with both Vue 2 & 3 (the "next" branch), and Vuex 3 + 4.

I found out that it can make some problems with Nuxt, so I'm afraid of going with this change.
But thank you anyway!

@HIMISOCOOL
Copy link
Author

HIMISOCOOL commented Sep 22, 2021

@davidmeirlevy
vue composition api is out of beta versions:
https://github.com/vuejs/composition-api/releases

and will follow vue 3's refinements for the forseeable future from what I know.
if you intend for this library to work for vue3 then I would suggest using https://github.com/vueuse/vue-demi which is maintained by antfu one of vues core team members, rather than the composition api directly.

what issues does nuxt have with peer deps? can we work around them?

@davidmeirlevy
Copy link
Contributor

for vue 3 we have a different branch ("next" branch) that publishes a "next" tag version for the package, and is designed to work specifically with vue 3 (unit tests changed and some of the codebase).

@HIMISOCOOL
Copy link
Author

ok so then these effects would be isolated from the next branch, which we could make a similar change for but with the relevant versions of vuex and @VUE packages.

Is there an open issue for the nuxt peer dependencies issue? Id like to read up on that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants