Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vue-cli transpile config #54

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kaisensan
Copy link

@kaisensan kaisensan commented Oct 22, 2021

I believe there's an error in current vue-cli transpile config. It doesn't work as it is (at least not for me), and taking in consideration what's suggested for webpack right above, I think it should be exclude instead of include.

@davidmeirlevy
Copy link
Contributor

@kaisen-san
It actually depends, because you can't really use both exclude and include, and it's very confusing (what happens when there's a conflict between them - what should the bundler do?).
It will be great to show both cases:

  • if you don't have an exclude - use include.
  • if you use the exclude already for other directories - use your version.

@kaisensan
Copy link
Author

kaisensan commented Oct 22, 2021

Hello @davidmeirlevy, I'm not sure if I get your point. I was referring to this example here. The way it's described there, it seemed to me that the example below, using vue-cli, was supposed to be equivalent to that (and as such, use exclude instead of include). I only have vue.config.js in my solution, so I don't think there would be any conflicts, but I assume the behavior should be the same either using webpack.config.js or vue.config.js.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants